-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: set right null flag for constant value #23172
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d8a1eb9
|
@fzhedu: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: #14912 did not thoroughly set right null flag for constant value, so this PR aims to do that. It has to keep the expression and schema item consistent. For example: select -1 from t; the expression (-1) is not null, and its returning schema contains a not-null column. As a result, plan_to_pb will get consistent plan, avoiding errors in TiFlash.
What is changed and how it works?
Proposal: xxx
What's Changed:
we set null flag for constants in two aspects:
How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note