expression: add not null flag in PB when constant not null #14912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
SunRunAway
reviewed
Feb 24, 2020
| return nil | ||
| } | ||
| if !x.Value.IsNull() { | ||
| pbExpr.FieldType.Flag |= uint32(mysql.NotNullFlag) |
There was a problem hiding this comment.
Is it better to put these code into Constant.GetType?
Codecov Report
@@ Coverage Diff @@
## master #14912 +/- ##
===========================================
Coverage 80.5274% 80.5274%
===========================================
Files 502 502
Lines 132761 132761
===========================================
Hits 106909 106909
Misses 17492 17492
Partials 8360 8360 |
|
/run-all-tests |
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-all-tests |
lzmhhh123
force-pushed
the
bug-fix/add_not_null_flag_for_constant_expr
branch
from
fc5d679 to
2f628f7
Compare
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says. We didn't set the not null flag for constant expression.
What is changed and how it works?
Check whether the constant is null and set the not null flag.
Check List
Tests
Side effects
Related changes