-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brie: set default config for backup and restore #18768
brie: set default config for backup and restore #18768
Conversation
058bfd8
to
00ca81f
Compare
Please run |
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #18768 +/- ##
===========================================
Coverage 79.2029% 79.2029%
===========================================
Files 542 542
Lines 146247 146247
===========================================
Hits 115832 115832
Misses 21080 21080
Partials 9335 9335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
1 similar comment
/run-unit-test |
LGTM |
@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack). |
What problem does this PR solve?
Problem Summary:
BR and BR in SQL both use the same function
RunBackup
RunRestore
as the entrance of backup/restore job.BR add some new config and check then adjust these configs before entrance, so the adjust step is not included in BR in SQL.it will cause the bug as same as #18750
What is changed and how it works?
What's Changed:
Set all new created config with default value in BR in SQL
Related changes
Check List
Tests
Release note