Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brie: set default config for backup and restore #18768

Merged
merged 4 commits into from
Jul 24, 2020

Conversation

3pointer
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

BR and BR in SQL both use the same function RunBackup RunRestore as the entrance of backup/restore job.
BR add some new config and check then adjust these configs before entrance, so the adjust step is not included in BR in SQL.it will cause the bug as same as #18750

What is changed and how it works?

What's Changed:
Set all new created config with default value in BR in SQL

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • No release note

@3pointer 3pointer requested a review from a team as a code owner July 24, 2020 08:29
@3pointer 3pointer requested review from SunRunAway and removed request for a team July 24, 2020 08:29
@3pointer 3pointer force-pushed the set_default_brie_config branch from 058bfd8 to 00ca81f Compare July 24, 2020 08:36
@kennytm
Copy link
Contributor

kennytm commented Jul 24, 2020

Please run go mod tidy.

@github-actions github-actions bot added the sig/execution SIG execution label Jul 24, 2020
@jebter
Copy link

jebter commented Jul 24, 2020

/run-unit-test

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #18768 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18768   +/-   ##
===========================================
  Coverage   79.2029%   79.2029%           
===========================================
  Files           542        542           
  Lines        146247     146247           
===========================================
  Hits         115832     115832           
  Misses        21080      21080           
  Partials       9335       9335           

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@kennytm,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

@jebter
Copy link

jebter commented Jul 24, 2020

/run-unit-test

1 similar comment
@kennytm
Copy link
Contributor

kennytm commented Jul 24, 2020

/run-unit-test

@overvenus
Copy link
Member

LGTM

@ti-srebot
Copy link
Contributor

@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

@ti-srebot
Copy link
Contributor

@jebter,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants