Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brie: add default backup gc-ttl to 5m #18750

Merged
merged 2 commits into from
Jul 24, 2020
Merged

brie: add default backup gc-ttl to 5m #18750

merged 2 commits into from
Jul 24, 2020

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jul 23, 2020 •
edited
Loading

What problem does this PR solve?

Problem Summary:
If not set default gc-ttl in backup, it will cause (1105, 'non-positive interval for NewTicker') when use Backup SQL.

What is changed and how it works?

What's Changed:
Set default gc-ttl when use Backup SQL.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Without this commit:

mysql>   backup database * to "noop://";
ERROR 1105 (HY000): non-positive interval for NewTicker

With this commit:

backup database * to "noop://""
mysql>   backup database * to "noop://";
+-------------+------+--------------------+---------------------+---------------------+
| Destination | Size | BackupTS           | Queue Time          | Execution Time      |
+-------------+------+--------------------+---------------------+---------------------+
| noop:       |    0 | 418253639611842562 | 2020-07-23 21:30:15 | 2020-07-23 21:30:15 |
+-------------+------+--------------------+---------------------+---------------------+
1 row in set (0.02 sec)

Release note

  • No release note

@3pointer 3pointer requested a review from a team as a code owner July 23, 2020 13:22
@3pointer 3pointer requested review from XuHuaiyu and removed request for a team July 23, 2020 13:22
@github-actions github-actions bot added the sig/execution SIG execution label Jul 23, 2020
@3pointer
Copy link
Contributor Author

/run-all-tests

2 similar comments
@3pointer
Copy link
Contributor Author

/run-all-tests

@3pointer
Copy link
Contributor Author

/run-all-tests

@jebter
Copy link

jebter commented Jul 23, 2020

/run-integration-copr-test

@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #18750 into master will decrease coverage by 0.0124%.
The diff coverage is 0.0000%.

@@               Coverage Diff                @@
##             master     #18750        +/-   ##
================================================
- Coverage   79.2234%   79.2110%   -0.0125%     
================================================
  Files           542        542                
  Lines        146242     146159        -83     
================================================
- Hits         115858     115774        -84     
+ Misses        21045      21043         -2     
- Partials       9339       9342         +3

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2020
@overvenus
Copy link
Member

/lgtm

@ti-srebot
Copy link
Contributor

@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

kennytm
kennytm approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@kennytm,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 24, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@3pointer merge failed.

@jebter
Copy link

jebter commented Jul 24, 2020

/run-check_dev_2

@jebter
Copy link

jebter commented Jul 24, 2020

/run-integration-ddl-test

@zhouqiang-cl zhouqiang-cl merged commit 9995ad7 into pingcap:master Jul 24, 2020
@jebter
Copy link

jebter commented Jul 24, 2020

/run-sqllogic-test-1

3pointer added a commit to 3pointer/tidb that referenced this pull request Jul 24, 2020
@3pointer @ti-srebot
brie: add default backup gc-ttl to 5m (pingcap#18750)
36adecb 
Co-authored-by: ti-srebot <[email protected]>
@3pointer 3pointer mentioned this pull request Jul 24, 2020
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 24, 2020
@3pointer @ti-srebot
cherry pick pingcap#18750 to release-4.0
ddd2dc6 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 24, 2020
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18755

jebter pushed a commit that referenced this pull request Jul 24, 2020
@3pointer @ti-srebot
brie: add default backup gc-ttl to 5m (#18750) (#18754)
ef4790f 
Co-authored-by: ti-srebot <[email protected]>

Co-authored-by: ti-srebot <[email protected]>
This was referenced Jul 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@kennytm kennytm kennytm approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@3pointer @jebter @tiancaiamao @overvenus @ti-srebot @lzmhhh123 @kennytm @zhouqiang-cl