Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix potential timezone related bugs caused by time.Local (#14572) #16187

Merged
merged 7 commits into from
Apr 22, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 8, 2020

cherry-pick #14572 to release-3.1


What problem does this PR solve?

#13626

What is changed and how it works?

Check List

Tests

None

Code changes

None

Side effects

None

Related changes

None

Release note

None

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reafans Please help to resolve the conflict.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2020
@zz-jason zz-jason requested a review from SunRunAway April 15, 2020 04:07
@reafans
Copy link
Contributor

reafans commented Apr 22, 2020

/run-unit-test

@reafans
Copy link
Contributor

reafans commented Apr 22, 2020

@SunRunAway PTAL

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 22, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

Your auto merge job has been accepted, waiting for:

  • 16649

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit 8633b0d into pingcap:release-3.1 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants