Potential timezone related bugs caused by gotime.Local location

[bb7133]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?
   When dealing with timestamps, currently there are several pieces of codes that used gotime.Local as the timezone location rather than system/global/session variables, which may lead to unexpected errors:

• tidb/types/mytime.go

  Line 79 in 61f24d2

  // TODO: Consider time_zone variable.

• tidb/types/time.go

  Line 433 in 61f24d2

  t1 := gotime.Date(1, 1, 1, hour, minute, second, microsecond*1000, gotime.Local)

• ...

  For example, "Invalid time format" caused by time zone issue #13605 is a bug caused by such codes, we should try to avoid using gotime.Local to prevent such errors.

2. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
   Such codes exist in all TiDB versions.

[Rustin170506]

I am working on it.

[bb7133]

Thanks! @Rustin-Liu

[fzhedu]

@bb7133 can we close this issue?

[Rustin170506]

I remember it seems that we still have this problem in some places. So maybe we can find all the problems and open a new issue to track them.

Or just keep this and update the issue desc? @fzhedu cc: @bb7133

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Not a bug

1. Remove the 'type/bug' label
2. Add notes to indicate why it is not a bug

Duplicate bug

1. Add the 'type/duplicate' label
2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions