gc_worker: Skip TiFlash nodes when doing UnsafeDestroyRange and Green GC #15505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15505 +/- ##
===========================================
Coverage 80.4264% 80.4264%
===========================================
Files 502 502
Lines 134278 134278
===========================================
Hits 107995 107995
Misses 17806 17806
Partials 8477 8477 |
youjiali1995
added
the
priority/release-blocker
store/tikv/gcworker/gc_worker.go
Outdated
| engineLabelTiKV = "tikv" | ||
| ) | ||
|
|
||
| // needsGCOperationForStore checks if the store-level quests related to GC needs to be sent to the store. The store-level |
There was a problem hiding this comment.
Suggested change
| // needsGCOperationForStore checks if the store-level quests related to GC needs to be sent to the store. The store-level | |
| // needsGCOperationForStore checks if the store-level requests related to GC needs to be sent to the store. The store-level |
|
Manual test goes well. This branch: |
youjiali1995
approved these changes
Mar 20, 2020
MyonKeminta
added
status/can-merge
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 20, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #15516 |
MyonKeminta
added a commit
to MyonKeminta/tidb
that referenced
this pull request
Mar 27, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15496
Problem Summary: GC delete range phase and (if green gc is enabled) resolve lock phase cannot successfully run when there are TiFlash nodes in the cluster.
What is changed and how it works?
What's Changed: Filters out TiFlash nodes when sending UnsafeDestroyRange and Green GC related stuff, according to the store's "engine" label. But note that it's possible to be broken when the label is incorrectly configured (see tikv/tikv#7153).
How it Works: For a TiFlash node, it uses other approach to delete dropped tables, so it's safe to skip sending UnsafeDestroyRange requests; it has only learner peers and their data must exist in TiKV, so it's safe to skip physical resolve locks for it. So in theory GC is still correct.
Related changes
Check List
Tests
Side effects
Release note
(I'm not sure if this is needed since it's related to TiFlash)