Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC delete range doesn't work when the cluster has TiFlash #15496

Closed
MyonKeminta opened this issue Mar 19, 2020 · 0 comments · Fixed by #15505
Closed

GC delete range doesn't work when the cluster has TiFlash #15496

MyonKeminta opened this issue Mar 19, 2020 · 0 comments · Fixed by #15505
Assignees
Labels
component/GC severity/major type/bug The issue is confirmed as a bug.

Comments

@MyonKeminta
Copy link
Contributor

Bug Report

1. What did you do?

In a cluster that has TiFlash, drop a table (which causes delete range in GC after gc_lifetime expires)

2. What did you expect to see?

GC runs correctly

3. What did you see instead?

GC's delete range phase finishes with error like:

[2020/03/17 14:54:38.206 +00:00] [ERROR] [gc_worker.go:590] ["[gc worker] delete range failed on range"] [uuid=5c31204fb30000d] [startKey=74800000000000005f] [endKey=748000000000000060] [error="[gc worker] destroy range finished with errors: [rpc error: code = Unimplemented desc =  rpc error: code = Unimplemented desc =  rpc error: code = Unimplemented desc = ]"]

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

v4.0.0-beta.1

To fix this, TiDB should skip sending UnsafeDestroyRange to TiFlash stores. It can distinguish it by the store's labels. However in case the labels are not set correctly, it's possible that TiKV node can be skipped too (see tikv/tikv#7153 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/GC severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants