Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl,executor: add auto_random column option (#13127, #14489) #14555

Merged
merged 2 commits into from
Feb 12, 2020
Merged

ddl,executor: add auto_random column option (#13127, #14489) #14555

merged 2 commits into from
Feb 12, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jan 20, 2020 •
edited
Loading

Cherry-pick #13127, #14489

Conflict files:

both modified:   config/config.go
both modified:   config/config_test.go
both modified:   ddl/ddl.go
both modified:   ddl/ddl_api.go
both modified:   ddl/serial_test.go
both modified:   executor/ddl_test.go
both modified:   executor/executor_test.go
both modified:   executor/show_test.go
both modified:   go.mod
both modified:   go.sum
both modified:   infoschema/builder.go
deleted by us:   infoschema/metricschema/tables.go
both modified:   infoschema/tables.go
both modified:   meta/autoid/autoid.go
both modified:   meta/autoid/errors.go
both modified:   sessionctx/binloginfo/binloginfo.go
both modified:   sessionctx/binloginfo/binloginfo_test.go
both modified:   table/tables/partition.go
both modified:   table/tables/tables.go

@tangenta tangenta force-pushed the autorand-release-3.1 branch from b1c8376 to fc42d0b Compare January 20, 2020 08:24
@tangenta tangenta requested review from AilinKid and bb7133 January 20, 2020 09:59
@bb7133
Copy link
Member

bb7133 commented Jan 20, 2020

/run-unit-test

bb7133
bb7133 reviewed Jan 20, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2020
@bb7133 bb7133 added this to the v3.1.0-rc milestone Jan 20, 2020
AilinKid
AilinKid reviewed Jan 23, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

/run-unit-test

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 3, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 3, 2020

@tangenta merge failed.

@tangenta
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 10, 2020

Sorry @tangenta, you don't have permission to trigger auto merge event on this branch.

@bb7133
Copy link
Member

bb7133 commented Feb 11, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 11, 2020

@tangenta merge failed.

@bb7133
Copy link
Member

bb7133 commented Feb 11, 2020

/run-unit-test

@pingcap pingcap deleted a comment from sre-bot Feb 11, 2020
@tangenta
Copy link
Contributor Author

/bench

@bb7133
Copy link
Member

bb7133 commented Feb 12, 2020

/bench

@zyxbest
Copy link
Contributor

zyxbest commented Feb 12, 2020

/run-unit-test

@tangenta tangenta force-pushed the autorand-release-3.1 branch 2 times, most recently from 301a5fc to 781a44c Compare February 12, 2020 08:42
@tangenta tangenta force-pushed the autorand-release-3.1 branch from 781a44c to 472ae25 Compare February 12, 2020 09:03
@zyxbest
Copy link
Contributor

zyxbest commented Feb 12, 2020

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Feb 12, 2020

/run-wasm-build

@bb7133
Copy link
Member

bb7133 commented Feb 12, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 12, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 12, 2020

@tangenta merge failed.

@5kbpers
Copy link
Contributor

5kbpers commented Feb 12, 2020

/build-wasm

bb7133
bb7133 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 1516653 into pingcap:release-3.1 Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v3.1.0-rc
Development

Successfully merging this pull request may close these issues.
6 participants
@tangenta @bb7133 @AilinKid @sre-bot @zyxbest @5kbpers