Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix shard row id bits test #14489

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Fix #14261.

What is changed and how it works?

Start the transaction 100 times instead of once to reduce the possibility of a test failure.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note

@tangenta tangenta force-pushed the shard_rowid_test branch 2 times, most recently from 5b753d4 to 0e16d6c Compare January 16, 2020 07:18
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jan 16, 2020

BTW, the idea of "insert 100 rows as 1 statement" is from me, sorry for that.

@bb7133 bb7133 added type/bugfix This PR fixes a bug. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jan 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSuite8.TestShardRowIDBits failed
4 participants