-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix transaction lazy initialization in pessimistic mode (#14446) #14474
Merged
jackysp
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-562a448b7db7
Jan 15, 2020
Merged
*: fix transaction lazy initialization in pessimistic mode (#14446) #14474
jackysp
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-562a448b7db7
Jan 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
/run-all-tests |
sre-bot
requested review from
cfzjywxk,
coocood,
crazycs520,
lysu,
tiancaiamao and
youjiali1995
January 14, 2020 08:48
LGTM |
bb7133
reviewed
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bb7133
approved these changes
Jan 15, 2020
/run-unit-test |
/merge |
Your auto merge job has been accepted, waiting for 14439 |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jan 15, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #14446 to release-3.0
Signed-off-by: Shuaipeng Yu [email protected]
What problem does this PR solve?
The transaction should also be initialized lazily in the pessimistic mode.
What is changed and how it works?
Do not active Txn when handling pessimistic DMLs.
Check List
Tests
Code changes
Related changes