Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix transaction lazy initialization in pessimistic mode #14446

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jan 10, 2020

Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

The transaction should also be initialized lazily in the pessimistic mode.

What is changed and how it works?

Do not active Txn when handling pessimistic DMLs.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

@jackysp jackysp added type/bugfix This PR fixes a bug. sig/transaction SIG:Transaction labels Jan 10, 2020
@coocood
Copy link
Member

coocood commented Jan 10, 2020

LGTM

@jackysp
Copy link
Member Author

jackysp commented Jan 10, 2020

/run-all-tests

Signed-off-by: Shuaipeng Yu <[email protected]>
@jackysp
Copy link
Member Author

jackysp commented Jan 11, 2020

/run-all-tests

Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member Author

jackysp commented Jan 14, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2020

Your auto merge job has been accepted, waiting for 14459

@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2020

@jackysp merge failed.

@tiancaiamao
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2020

cherry pick to release-3.0 in PR #14474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants