Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Fix "Invalid time format" caused by daily saving time (#13614) #13624

Merged
merged 4 commits into from
Nov 21, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 20, 2019

cherry-pick #13614 to release-2.1


What problem does this PR solve?

Fix #13605

What is changed and how it works?

Some regions use daylight saving time.

In MySQL, it will throw the error "Invalid time format" when use the datetime between the advanced hour of daylight saving time (e.g. 2018/3/11 2:00~3:00 in Los Angeles). Actually, if the @@time_zone sql variable is set to region where uses daylight saving time, the error occurred. But if the @@time_zone is other region, no error occurred, even if the system time zone is the region where uses daylight saving time.

But TiDB will throw an unexpected error "Invalid time format" when the timezone of system is in region where use daylight saving time.

Fix method:

When checking the time, we use the SQL variable @@time_zone instead of directly use the timezone of system.

In details, In checkTimestampType function, we use the TimeZone of statementContext, instead of local timezone provided by Golang.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 20, 2019

/run-all-tests

@Deardrops
Copy link
Contributor

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops
Copy link
Contributor

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Nov 20, 2019

/run-unit-test

2 similar comments
@Deardrops
Copy link
Contributor

/run-unit-test

@Deardrops
Copy link
Contributor

/run-unit-test

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 21, 2019
@bb7133 bb7133 merged commit 39b8370 into pingcap:release-2.1 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants