types: Fix "Invalid time format" caused by daily saving time #13614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #13614 +/- ##
===========================================
Coverage 79.9157% 79.9157%
===========================================
Files 472 472
Lines 115583 115583
===========================================
Hits 92369 92369
Misses 15949 15949
Partials 7265 7265 |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
bb7133
reviewed
Nov 20, 2019
|
/run-all-tests |
|
LGTM |
AilinKid
added
status/LGT3
|
cherry pick to release-2.1 in PR #13624 |
|
cherry pick to release-3.0 in PR #13625 |
sre-bot
added a commit
that referenced
this pull request
Nov 20, 2019
bb7133
pushed a commit
that referenced
this pull request
Nov 21, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #13605
What is changed and how it works?
Some regions use daylight saving time.
In MySQL, it will throw the error "Invalid time format" when use the
datetimebetween the advanced hour of daylight saving time (e.g. 2018/3/11 2:00~3:00 in Los Angeles). Actually, if the@@time_zonesql variable is set to region where uses daylight saving time, the error occurred. But if the@@time_zoneis other region, no error occurred, even if the system time zone is the region where uses daylight saving time.But TiDB will throw an unexpected error "Invalid time format" when the timezone of system is in region where use daylight saving time.
Fix method:
When checking the time, we use the SQL variable
@@time_zoneinstead of directly use the timezone of system.In details, In
checkTimestampTypefunction, we use theTimeZoneofstatementContext, instead of local timezone provided by Golang.Check List
Tests
Code changes
Side effects
Related changes
Release note