types/data: the bit data type should be treat as uint64 (#11951) #12616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
reviewed
Oct 13, 2019
| @@ -471,3 +472,21 @@ func (s *testSuite) TestPartitionInsertOnDuplicate(c *C) { | |||
| tk.MustQuery(`select * from t2`).Check(testkit.Rows("1 1")) | |||
|
|
|||
| } | |||
|
|
|||
| func (s *testSuite) TestBitInRange(c *C) { | |||
There was a problem hiding this comment.
in #11951, it is callled TestBit, why here is it called TetBItInRange
SunRunAway
changed the title
|
Hi @SunRunAway I created this PR because the cherry pick failed because of code conflicts and that's why the method name changed. please see the PR comments and the error log it shows build error.
|
|
Hi, I've resolved the conflicts in #12424, and will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix cherry-pick #11951 to release-2.1 . related issue for automatically pick is in here