Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types/data: the bit data type should be treat as uint64 #11951

Merged
merged 9 commits into from
Sep 26, 2019
Merged

types/data: the bit data type should be treat as uint64 #11951

merged 9 commits into from
Sep 26, 2019

Conversation

gaoxingliang
Copy link
Contributor

What problem does this PR solve?

Fix #11895
the -1 can't be insert into a bit column.

What is changed and how it works?

  1. when convert to mysql bit, mapped it to unsigned int.
  2. the error is wrong (it should be data too long instead of out of range)

Check List

Tests

  • Unit test -- added test cases

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #11951 into master will increase coverage by 0.0834%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #11951        +/-   ##
================================================
+ Coverage   80.0246%   80.1081%   +0.0834%     
================================================
  Files           462        462                
  Lines        103067     103962       +895     
================================================
+ Hits          82479      83282       +803     
- Misses        14717      14818       +101     
+ Partials       5871       5862         -9

@zz-jason zz-jason added the type/bugfix This PR fixes a bug. label Sep 10, 2019
types/datum.go Outdated Show resolved Hide resolved
executor/insert_test.go Outdated Show resolved Hide resolved
@gaoxingliang
Copy link
Contributor Author

Can anyone help to review this PR?

@zz-jason
Copy link
Member

Can anyone help to review this PR?

Sorry for the late reply. @SunRunAway @qw4990 PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added needs-cherry-pick-2.1 status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

Your auto merge job has been accepted, waiting for 12224

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

@gaoxingliang merge failed.

@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

cherry pick to release-3.0 in PR #12423

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

cherry pick to release-2.1 in PR #12424

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not insert -1 as Type BIT
5 participants