-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TiDB-Lightning will print some sensitive message when it runs in server mode #36374
Comments
/remove-label affects-6.2 |
I'm pretty sure #36375's regexp and test case are both written wrongly tidb/br/pkg/utils/sensitive.go Line 10 in a1b38f8
tidb/br/pkg/utils/sensitive_test.go Line 17 in a1b38f8
you don't need to escape the backslash inside the backquote-strings! |
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
Run TiDB-Lightning in server mode and start an import task.
2. What did you expect to see? (Required)
Lightning's log doesn't contain sensitive information.
3. What did you see instead (Required)
Lightning's log contains sensitive information.
4. What is your TiDB version? (Required)
master
The text was updated successfully, but these errors were encountered: