lightning: Don't log "received task config" in server mode (#52336) (#…

…52497) close #36374
pingcap · Apr 11, 2024 · faeb33e · faeb33e
1 parent fd9583b
commit faeb33e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 69 deletions.
diff --git a/br/pkg/lightning/lightning.go b/br/pkg/lightning/lightning.go
@@ -753,8 +753,7 @@ func (l *Lightning) handlePostTask(w http.ResponseWriter, req *http.Request) {
 		writeJSONError(w, http.StatusBadRequest, "cannot read request", err)
 		return
 	}
-	filteredData := utils.HideSensitive(string(data))
-	log.L().Info("received task config", zap.String("content", filteredData))
+	log.L().Info("received task config")
 
 	cfg := config.NewConfig()
 	if err = cfg.LoadFromGlobal(l.globalCfg); err != nil {

diff --git a/br/pkg/utils/BUILD.bazel b/br/pkg/utils/BUILD.bazel
@@ -20,7 +20,6 @@ go_library(
         "retry.go",
         "safe_point.go",
         "schema.go",
-        "sensitive.go",
         "store_manager.go",
         "suspend_importing.go",
         "worker.go",
@@ -89,12 +88,11 @@ go_test(
         "retry_test.go",
         "safe_point_test.go",
         "schema_test.go",
-        "sensitive_test.go",
         "suspend_importing_test.go",
     ],
     embed = [":utils"],
     flaky = True,
-    shard_count = 38,
+    shard_count = 37,
     deps = [
         "//br/pkg/errors",
         "//br/pkg/metautil",

diff --git a/br/pkg/utils/sensitive.go b/br/pkg/utils/sensitive.go
diff --git a/br/pkg/utils/sensitive_test.go b/br/pkg/utils/sensitive_test.go