Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumpling: The SortByPk option is missing a flag #31097

Closed
dveeden opened this issue Dec 28, 2021 · 2 comments · Fixed by #31098
Closed

Dumpling: The SortByPk option is missing a flag #31097

dveeden opened this issue Dec 28, 2021 · 2 comments · Fixed by #31098
Assignees
Labels
component/dumpling This is related to Dumpling of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@dveeden
Copy link
Contributor

dveeden commented Dec 28, 2021

Bug Report

1. Minimal reproduce step (Required)

Inspect the code: There is a SortByPk option, but no flag to set it.

This causes issues when exporting data from Vitess as that doesn't support queries like this if the table is sharded:

SELECT * FROM tbl ORDER BY col1;

However it does support:

SELECT col1, col2, ... FROM tbl ORDER BY col1;

Or:

SELECT * FROM tbl

The column in the ORDER BY has to be explicitly named in the SELECT-list.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@dveeden dveeden added the type/bug The issue is confirmed as a bug. label Dec 28, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Dec 28, 2021

Related: pingcap/docs#5783

@aytrack aytrack added the component/dumpling This is related to Dumpling of TiDB. label Dec 29, 2021
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants