Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration: Add information about Vitess to TiDB migration #5783

Merged
merged 17 commits into from
Nov 18, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jun 14, 2021

What is changed, added or deleted? (Required)

Related to:

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 14, 2021 20:29
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2021
@dveeden dveeden requested review from morgo and kolbe June 14, 2021 20:29
@dveeden
Copy link
Contributor Author

dveeden commented Jun 14, 2021

Comments from @morgo from when this was part of another PR: #5782 (comment)

@TomShawn TomShawn requested a review from winoros June 15, 2021 01:58
@TomShawn TomShawn assigned TomShawn and Liuxiaozhen12 and unassigned TomShawn Jun 15, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.0 translation/doing This PR's assignee is translating this PR. labels Jun 15, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 15, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Jun 17, 2021

Things to note:

  • The MySQL instances hosting the data for Vitess have a _vt schema. This is metadata and probably should be excluded.
  • The schema in the backend database has a vt_ prefix that should probably be removed. Not sure where in the process this should be done.

If we try to run dumpling directly on vtgate this happens:

[dvaneeden@dve-carbon local]$ tiup dumpling -P 15306
Starting component `dumpling`: /home/dvaneeden/.tiup/components/dumpling/v5.0.2/dumpling -P 15306
Release version: v5.0.2
Git commit hash: 95099237b7beb80f66efaac9f3e02bd01e68bcc2
Git branch:      heads/refs/tags/v5.0.2
Build timestamp: 2021-06-07 08:39:29Z
Go version:      go version go1.13 linux/amd64

[2021/06/17 14:27:16.486 +02:00] [INFO] [versions.go:55] ["Welcome to dumpling"] ["Release Version"=v5.0.2] ["Git Commit Hash"=95099237b7beb80f66efaac9f3e02bd01e68bcc2] ["Git Branch"=heads/refs/tags/v5.0.2] ["Build timestamp"="2021-06-07 08:39:29"] ["Go Version"="go version go1.13 linux/amd64"]
[2021/06/17 14:27:16.488 +02:00] [INFO] [config.go:600] ["detect server type"] [type=MySQL]
[2021/06/17 14:27:16.488 +02:00] [INFO] [config.go:619] ["detect server version"] [version=8.0.25]
[2021/06/17 14:27:16.488 +02:00] [INFO] [dump.go:83] ["begin to run Dump"] [conf="{\"s3\":{\"endpoint\":\"\",\"region\":\"\",\"storage-class\":\"\",\"sse\":\"\",\"sse-kms-key-id\":\"\",\"acl\":\"\",\"access-key\":\"\",\"secret-access-key\":\"\",\"provider\":\"\",\"force-path-style\":true,\"use-accelerate-endpoint\":false},\"gcs\":{\"endpoint\":\"\",\"storage-class\":\"\",\"predefined-acl\":\"\",\"credentials-file\":\"\"},\"AllowCleartextPasswords\":false,\"SortByPk\":true,\"NoViews\":true,\"NoHeader\":false,\"NoSchemas\":false,\"NoData\":false,\"CompleteInsert\":false,\"TransactionalConsistency\":true,\"EscapeBackslash\":true,\"DumpEmptyDatabase\":true,\"PosAfterConnect\":false,\"CompressType\":0,\"Host\":\"127.0.0.1\",\"Port\":15306,\"Threads\":4,\"User\":\"root\",\"Security\":{\"CAPath\":\"\",\"CertPath\":\"\",\"KeyPath\":\"\"},\"LogLevel\":\"info\",\"LogFile\":\"\",\"LogFormat\":\"text\",\"OutputDirPath\":\"./export-2021-06-17T14:27:16+02:00\",\"StatusAddr\":\":8281\",\"Snapshot\":\"\",\"Consistency\":\"flush\",\"CsvNullValue\":\"\\\\N\",\"SQL\":\"\",\"CsvSeparator\":\",\",\"CsvDelimiter\":\"\\\"\",\"Databases\":[],\"Where\":\"\",\"FileType\":\"sql\",\"ServerInfo\":{\"HasTiKV\":false,\"ServerType\":1,\"ServerVersion\":\"8.0.25\"},\"Rows\":0,\"ReadTimeout\":900000000000,\"TiDBMemQuotaQuery\":0,\"FileSize\":0,\"StatementSize\":1000000,\"SessionParams\":{},\"Tables\":null}"]
[2021/06/17 14:27:16.490 +02:00] [ERROR] [main.go:77] ["dump failed error stack info"] [error="sql: START TRANSACTION /*!40108 WITH CONSISTENT SNAPSHOT */: Error 1105: syntax error at position 55 near 'WITH'"] [errorVerbose="Error 1105: syntax error at position 55 near 'WITH'\nsql: START TRANSACTION /*!40108 WITH CONSISTENT SNAPSHOT */\ngithub.com/pingcap/dumpling/v4/export.createConnWithConsistency\n\tgithub.com/pingcap/dumpling@/v4/export/sql.go:587\ngithub.com/pingcap/dumpling/v4/export.(*Dumper).Dump\n\tgithub.com/pingcap/dumpling@/v4/export/dump.go:119\nmain.main\n\tgithub.com/pingcap/dumpling@/cmd/dumpling/main.go:74\nruntime.main\n\truntime/proc.go:203\nruntime.goexit\n\truntime/asm_amd64.s:1357"]

dump failed: sql: START TRANSACTION /*!40108 WITH CONSISTENT SNAPSHOT */: Error 1105: syntax error at position 55 near 'WITH'
Error: run `/home/dvaneeden/.tiup/components/dumpling/v5.0.2/dumpling` (wd:/home/dvaneeden/.tiup/data/SaaugB3) failed: exit status 1

Even with --consistency none this happens

@dveeden dveeden marked this pull request as draft September 2, 2021 08:58
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2021
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Sep 6, 2021
@TomShawn TomShawn added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Nov 19, 2021
@TomShawn TomShawn added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 11, 2022
@shichun-0415 shichun-0415 added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Aug 13, 2022
@dveeden dveeden requested a review from qiancai March 5, 2024 12:10
@qiancai
Copy link
Collaborator

qiancai commented Apr 12, 2024

@Frank945946 would you please take a look at this PR? Thanks.

migrate-from-vitess.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Apr 12, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

migrate-from-vitess.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some suggestions

migrate-from-vitess.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented May 22, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, with some suggestions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 13, 2024

@mjonss @qiancai This PR has been sitting here for years now. What things are required to get this merged?

@qiancai
Copy link
Collaborator

qiancai commented Nov 14, 2024

@mjonss @qiancai This PR has been sitting here for years now. What things are required to get this merged?

It looks good to me. Let me start working on the corresponding Chinese PR and merge both PRs afterwards.

migrate-from-vitess.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2024
Copy link

ti-chi-bot bot commented Nov 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2023-11-17 09:28:35.491006828 +0000 UTC m=+4414113.078116958: ☑️ agreed by lance6716.
  • 2024-11-15 01:56:56.753867322 +0000 UTC m=+580578.944736320: ☑️ agreed by hfxsd.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 15, 2024
@qiancai
Copy link
Collaborator

qiancai commented Nov 18, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 18, 2024
@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 61cd80f into pingcap:master Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.