Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump operator version to 1.3.1 #4433

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Bump operator version to 1.3.1 #4433

merged 3 commits into from
Feb 23, 2022

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@KanShiori KanShiori mentioned this pull request Feb 22, 2022
Closed
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #4433 (caa2c4c) into master (355d4fc) will increase coverage by 5.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4433      +/-   ##
==========================================
+ Coverage   62.39%   67.85%   +5.46%     
==========================================
  Files         184      188       +4     
  Lines       19775    22177    +2402     
==========================================
+ Hits        12339    15049    +2710     
+ Misses       6293     5912     -381     
- Partials     1143     1216      +73
Flag Coverage Δ
e2e 46.43% <ø> (?)
unittest 62.38% <ø> (-0.02%) ⬇️

DanielZhangQD
DanielZhangQD approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ce2445

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-br

1 similar comment
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-br

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-across-kubernetes

1 similar comment
@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-across-kubernetes

@DanielZhangQD DanielZhangQD merged commit b2a0f19 into pingcap:master Feb 23, 2022
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Feb 23, 2022
@KanShiori @ti-srebot
cherry pick pingcap#4433 to release-1.3
94a170a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.3 in PR #4438

DanielZhangQD pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot @KanShiori
cherry pick #4433 to release-1.3 (#4438)
58fba3f 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Shiori <[email protected]>
@KanShiori KanShiori deleted the bump_v1.3.1 branch February 24, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-1.3 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KanShiori @ti-chi-bot @codecov-commenter @DanielZhangQD @ti-srebot @csuzhangxc