Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator version to 1.3.1 (#4433) #4438

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 23, 2022

cherry-pick #4433 to release-1.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb-operator repo:
git pr https://github.com/pingcap/tidb-operator/pull/4438

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb-operator.git pr/4438:release-1.3-b2a0f19c2ed3

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

@KanShiori you're already a collaborator in bot's repo.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 94a170a

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #4438 (94a170a) into release-1.3 (ce5d391) will increase coverage by 2.71%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-1.3    #4438      +/-   ##
===============================================
+ Coverage        62.37%   65.08%   +2.71%     
===============================================
  Files              184      188       +4     
  Lines            19775    22177    +2402     
===============================================
+ Hits             12334    14435    +2101     
- Misses            6296     6503     +207     
- Partials          1145     1239      +94     
Flag Coverage Δ
e2e 38.25% <ø> (?)
unittest 62.38% <ø> (+0.01%) ⬆️

@DanielZhangQD DanielZhangQD merged commit 58fba3f into pingcap:release-1.3 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants