Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error importer config #1415

Merged
merged 1 commit into from
Dec 25, 2019
Merged

fix error importer config #1415

merged 1 commit into from
Dec 25, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Dec 25, 2019 •
edited
Loading

Signed-off-by: Aylei [email protected]

What problem does this PR solve?

Cannot start tikv-importer using the default config

thread 'main' panicked at 'invalid auto generated configuration file /etc/tikv-importer/tikv-importer.toml, err unknown field `metrics`, expected one of `log-level`, `log-file`, `log-rotation-timespan`, `storage`, `server`, `metric`, `rocksdb`, `security`, `import`', src/import/config.rs:134:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Reference: https://github.com/tikv/importer/blob/master/etc/tikv-importer.toml

What is changed and how does it work?

A typo is fixed

Check List

Tests

  • Unit test
  • E2E test

Does this PR introduce a user-facing change?:

Fix the default tikv-importer configuration

@aylei aylei added the type/bug Something isn't working label Dec 25, 2019
@aylei
Copy link
Contributor Author

aylei commented Dec 25, 2019

/run-all-test

cofyc
cofyc approved these changes Dec 25, 2019
View reviewed changes
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add an e2e case for tikv-importer?

@aylei
Copy link
Contributor Author

aylei commented Dec 25, 2019

LGTM

add an e2e case for tikv-importer?

It is helpful but we may not do this, tikv-importer is going to integrated into the tikv process and we've not included tikv-importer in #1121 neither

tennix
tennix approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Dec 25, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit b918463 into pingcap:master Dec 25, 2019
@aylei
Copy link
Contributor Author

aylei commented Dec 25, 2019

/run-cherry-picker

@sre-bot sre-bot mentioned this pull request Dec 25, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2019

cherry pick to release-1.0 in PR #1417

sre-bot added a commit that referenced this pull request Dec 26, 2019
@sre-bot
fix error importer config (#1415) (#1417)
9d0b4a9
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@mikechengwei
zh:add tidbmonitor shards doc (#1415)
4560c88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@cofyc cofyc cofyc approved these changes

@weekface weekface Awaiting requested review from weekface

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
needs-cherry-pick-1.0 status/can-merge type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aylei @sre-bot @cofyc @tennix