Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error importer config (#1415) #1417

Merged
merged 3 commits into from
Dec 26, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 25, 2019

cherry-pick #1415 to release-1.0


Signed-off-by: Aylei [email protected]

What problem does this PR solve?

Cannot start tikv-importer using the default config

thread 'main' panicked at 'invalid auto generated configuration file /etc/tikv-importer/tikv-importer.toml, err unknown field `metrics`, expected one of `log-level`, `log-file`, `log-rotation-timespan`, `storage`, `server`, `metric`, `rocksdb`, `security`, `import`', src/import/config.rs:134:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Reference: https://github.com/tikv/importer/blob/master/etc/tikv-importer.toml

What is changed and how does it work?

A typo is fixed

Check List

Tests

  • Unit test
  • E2E test

Does this PR introduce a user-facing change?:

Fix the default tikv-importer configuration

@aylei
Copy link
Contributor

aylei commented Dec 26, 2019

/run-all-test

@weekface weekface added this to the v1.0.6 milestone Dec 26, 2019
@weekface
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 26, 2019

@sre-bot merge failed.

@weekface
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 26, 2019

Your auto merge job has been accepted, waiting for 1423

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 26, 2019

@sre-bot merge failed.

@aylei
Copy link
Contributor

aylei commented Dec 26, 2019

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 9d0b4a9 into pingcap:release-1.0 Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants