Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create_tidb_cluster_release variable does not work (#1062) #1066

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix create_tidb_cluster_release variable does not work (#1062) #1066

merged 1 commit into from
Oct 29, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Oct 29, 2019

cherry-pick #1062 to release-1.0

Signed-off-by: Aylei [email protected]

What problem does this PR solve?

close #1057

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Fix that the create_tidb_cluster_release variable in AWS terraform script does not work.

@DanielZhangQD @tennix @cofyc PTAL

@sre-bot sre-bot mentioned this pull request Oct 29, 2019
Merged
tennix
tennix approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 987c229 into pingcap:release-1.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

Assignees
No one assigned
Labels
area/terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @tennix @aylei