Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_tidb_cluster_release variable in aws terraform script does not work #1057

Closed
aylei opened this issue Oct 28, 2019 · 0 comments · Fixed by #1062
Closed

create_tidb_cluster_release variable in aws terraform script does not work #1057

aylei opened this issue Oct 28, 2019 · 0 comments · Fixed by #1062
Assignees
@aylei
Labels
area/terraform

Comments

@aylei
Copy link
Contributor

aylei commented Oct 28, 2019

Bug Report

[[email protected] tidb-operator]$grep -r create_tidb_cluster_release *
deploy/modules/aws/tidb-cluster/variables.tf:variable "create_tidb_cluster_release" {
[[email protected] tidb-operator]$

This variable is not used anywhere.
@aylei aylei self-assigned this Oct 28, 2019
@aylei aylei mentioned this issue Oct 28, 2019
Merged
@sre-bot sre-bot mentioned this issue Oct 29, 2019
Merged
yahonda pushed a commit that referenced this issue Dec 27, 2021
@ran-huang @TomShawn @DanielZhangQD
en: add doc for deploying multiple tidb operator (#1057)
7f0a2dd 
* en: add canary deployment of tidb operator

Signed-off-by: Ran <[email protected]>

* add summary

Signed-off-by: Ran <[email protected]>

* Apply suggestions from code review

Co-authored-by: TomShawn <[email protected]>

* update wording

Signed-off-by: Ran <[email protected]>

* Apply suggestions from code review

Co-authored-by: DanielZhangQD <[email protected]>

* align 1063

Signed-off-by: Ran <[email protected]>

* change file name

Signed-off-by: Ran <[email protected]>

* revert zh

Signed-off-by: Ran <[email protected]>

* trim spaces

Signed-off-by: Ran <[email protected]>

Co-authored-by: TomShawn <[email protected]>
Co-authored-by: DanielZhangQD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aylei aylei

Labels
area/terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix create_tidb_cluster_release variable does not work pingcap/tidb-operator
1 participant
@aylei