Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable unwind #2655

Merged
merged 7 commits into from
Aug 10, 2021
Merged

enable unwind #2655

merged 7 commits into from
Aug 10, 2021

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Aug 10, 2021 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

enable unwind to get the whole stack when TiFlash crashed

Issue Number: close #2616

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2021
@mengxin9014
Copy link
Contributor Author

/run-all-tests

JaySon-Huang
JaySon-Huang reviewed Aug 10, 2021
View reviewed changes
libs/libdaemon/cmake/find_unwind.cmake Outdated
@@ -7,6 +7,8 @@ else ()
option (USE_INTERNAL_UNWIND_LIBRARY "Set to FALSE to use system unwind library instead of bundled" OFF)
endif ()

option (ENABLE_UNWIgiND "Enable libunwind (better stacktraces)" ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we add these options in the root CMakeLists.txt of tics.
And should it be option (ENABLE_UNWIND ...) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is strange. even though the flag is not defined previously, CI builds it with unwind, anyone sees the reason?

@SchrodingerZhu
Copy link
Contributor

image

@JaySon-Huang

This comment has been minimized.

Sign in to view
@SchrodingerZhu
Copy link
Contributor

image

so strange! how comes it was previously in the build plan!

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Aug 10, 2021 •
edited
Loading

I add message(STATUS "unwind: ${ENABLE_UNWIND}") right after cmake_minimum_required (VERSION 2.8) in the root CMakeLists.txt, and it shows -- unwind: ON while running cmake 👀

So if a variables is not defined, it is "ON" by default? strange...

@SchrodingerZhu
Copy link
Contributor

@JaySon-Huang I suddenly remembered something: for aarch64, when I ported unwind for it, I compiled the target with -DENABLE_UNWIND=ON.

@SchrodingerZhu
Copy link
Contributor

The change itself LGTM.

@mengxin9014
Copy link
Contributor Author

I add message(STATUS "unwind: ${ENABLE_UNWIND}") right after cmake_minimum_required (VERSION 2.8) in the root CMakeLists.txt, and it shows -- unwind: ON while running cmake 👀

So if a variables is not defined, it is "ON" by default? strange...

I try to add it but it shows -- unwind: 😂

@JaySon-Huang JaySon-Huang added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.2 labels Aug 10, 2021
@mengxin9014
Copy link
Contributor Author

/run-all-tests

SchrodingerZhu
SchrodingerZhu approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2021
@JaySon-Huang
Copy link
Contributor

I try to add it but it shows -- unwind: 😂

Never mind, I think it is a cached variable by running the cmake before this PR: https://github.com/pingcap/tics/pull/2164/files#diff-dba8ba4a17d71a9b87fa0a9add4c267a3e93e45e4a0ee8a4d250233477605dd7L4

@JaySon-Huang JaySon-Huang removed needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.1 labels Aug 10, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 10, 2021
@JaySon-Huang
Copy link
Contributor

Remove some cherry-pick labels since it only affects release-5.2 and master.
And change the release note to be "None"

@ti-chi-bot ti-chi-bot merged commit 443f301 into pingcap:master Aug 10, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.2: error checking out 5.2: exit status 1. output: error: pathspec '5.2' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #2655 on top of branch "release-5.2":

failed to git fetch upstream: exit status 128

@Mini256
Copy link
Member

Mini256 commented Aug 10, 2021

/cherry-pick release-5.2

@ti-chi-bot
Copy link
Member

@Mini256: failed to apply #2655 on top of branch "release-5.2":

failed to git fetch upstream: exit status 128

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Mini256
Copy link
Member

Mini256 commented Aug 10, 2021

/cherry-pick release-5.2

@ti-chi-bot
Copy link
Member

@Mini256: failed to apply #2655 on top of branch "release-5.2":

failed to git fetch upstream: exit status 128

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 11, 2021
@mengxin9014 @ti-chi-bot
enable unwind (pingcap#2655)
429393c
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 11, 2021
Closed
@ti-chi-bot
Copy link
Member

@Mini256: new pull request created: #2666.

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 11, 2021
Merged
@ti-chi-bot
Copy link
Member

@Mini256: new pull request created: #2667.

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang JaySon-Huang deleted the dev/enableUnwind branch August 11, 2021 06:52
@Mini256
Copy link
Member

Mini256 commented Aug 11, 2021

/cherry-pick release-5.2

@ti-chi-bot
Copy link
Member

@Mini256: failed to apply #2655 on top of branch "release-5.2":

failed to git fetch upstream: exit status 128

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 11, 2021
@mengxin9014 @ti-chi-bot
enable unwind (pingcap#2655)
9351c0b
@ti-chi-bot
Copy link
Member

@Mini256: failed to apply #2655 on top of branch "release-5.2":

failed to git fetch upstream: exit status 128

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

JaySon-Huang pushed a commit that referenced this pull request Aug 11, 2021
@ti-chi-bot @mengxin9014
enable unwind (#2655) (#2667)
819f16b 
Co-authored-by: Meng Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 left review comments

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash crash but baseDeamon only throw top-level stack frame instead of the whole stack.
6 participants
@mengxin9014 @ti-chi-bot @SchrodingerZhu @JaySon-Huang @Mini256 @fuzhe1989