Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable unwind (#2655) #2667

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2655

What problem does this PR solve?

enable unwind to get the whole stack when TiFlash crashed

Issue Number: close #2616

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 11, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 11, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2021
@Mini256
Copy link
Member

Mini256 commented Aug 11, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-2655-to-release-5.2 branch 2 times, most recently from 693fbb4 to 0529e00 Compare August 11, 2021 07:13
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-2655-to-release-5.2 branch from 0529e00 to 9351c0b Compare August 11, 2021 08:00
@SchrodingerZhu
Copy link
Contributor

/run-all-tests

@Mini256
Copy link
Member

Mini256 commented Aug 11, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021
@Mini256 Mini256 removed their assignment Aug 11, 2021
@Mini256
Copy link
Member

Mini256 commented Aug 11, 2021

/type cherry-pick-for-release-5.2

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9351c0b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@JaySon-Huang JaySon-Huang merged commit 819f16b into pingcap:release-5.2 Aug 11, 2021
@JaySon-Huang JaySon-Huang deleted the cherry-pick-2655-to-release-5.2 branch August 11, 2021 14:03
@JaySon-Huang JaySon-Huang added this to the v5.2.0 milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants