Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add fips build support (#201) #216

Conversation

overvenus
Copy link
Member

Cherry-pick #201


What problem does this PR solve?

Issue Number: close #200

See pingcap/tidb#47949 for more details.

What is changed and how it works?

build:

ENABLE_FIPS=1 make

check:

go tool nm bin/ng-monitoring | grep boring

@ti-chi-bot ti-chi-bot bot requested review from breezewish and shenli December 11, 2023 06:04
@ti-chi-bot ti-chi-bot bot added the size/M label Dec 11, 2023
@mornyx
Copy link
Collaborator

mornyx commented Dec 11, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 11, 2023
Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-11 06:05:24.718677031 +0000 UTC m=+249815.755903973: ☑️ agreed by mornyx.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2f3445b into pingcap:feature/release-6.5-fips Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants