Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add fips build support #201

Merged
merged 2 commits into from
Nov 27, 2023
Merged

*: add fips build support #201

merged 2 commits into from
Nov 27, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Nov 15, 2023

What problem does this PR solve?

Issue Number: close #200

See pingcap/tidb#47949 for more details.

What is changed and how it works?

build:

ENABLE_FIPS=1 make

check:

go tool nm bin/ng-monitoring | grep boring

@ti-chi-bot ti-chi-bot bot requested review from iamxy and ngaut November 15, 2023 16:19
@ti-chi-bot ti-chi-bot bot added the size/M label Nov 15, 2023
@mornyx
Copy link
Collaborator Author

mornyx commented Nov 15, 2023

Seems CI fails on TiKV heap profiling, any ideas to help fix it? /cc @Connor1996

@Connor1996
Copy link
Member

Connor1996 commented Nov 16, 2023

@mornyx It's because http server is not ready to served while scraper already begins working. Better to make sure httpServer.Serve(listener); is called before calling conprof.Init()

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

ti-chi-bot bot commented Nov 21, 2023

@overvenus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mornyx mornyx mentioned this pull request Nov 23, 2023
Signed-off-by: mornyx <[email protected]>
@mornyx mornyx mentioned this pull request Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 23, 2023
Copy link

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 07:32:25.478481939 +0000 UTC m=+475974.143708132: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 23, 2023
Copy link

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, crazycs520, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [breezewish,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mornyx
Copy link
Collaborator Author

mornyx commented Nov 23, 2023

/merge

Copy link

ti-chi-bot bot commented Nov 23, 2023

@mornyx: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 24f1114 into main Nov 27, 2023
1 of 2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the mornyx/fips branch November 27, 2023 02:25
overvenus pushed a commit to overvenus/ng-monitoring that referenced this pull request Dec 11, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FIPS build support
5 participants