-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Pick serval PRs for ticdc compiling #664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: disksing <[email protected]> Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: Jay Lee <[email protected]> Signed-off-by: 5kbpers <[email protected]>
Add batch coprocessor function for TiFlash Engine. Signed-off-by: 5kbpers <[email protected]>
* pd: add UpdateServiceGCSafePoint method Signed-off-by: Shafreeck Sea <[email protected]> Signed-off-by: 5kbpers <[email protected]>
…Kv (pingcap#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <[email protected]> * build Co-authored-by: MyonKeminta <[email protected]> Signed-off-by: 5kbpers <[email protected]>
…olved-ts-4.0 Signed-off-by: 5kbpers <[email protected]>
overvenus
reviewed
Aug 17, 2020
proto/cdcpb.proto
Outdated
@@ -69,6 +69,7 @@ message Event { | |||
uint64 region_id = 1; | |||
uint64 index = 2; | |||
uint64 request_id = 7; | |||
repeated uint64 regions = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert the change? So we can merge other cherry-picks first.
This reverts commit c382b16. Signed-off-by: 5kbpers <[email protected]>
5kbpers
changed the title
[4.0] Pick #663 & serval PRs for ticdc compiling
[4.0] Pick serval PRs for ticdc compiling
Aug 18, 2020
overvenus
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MyonKeminta
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #584 #594 #595 #597 #586 #603 #581