pdpb: add replicate_mode #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
BusyJay
reviewed
Mar 23, 2020
proto/replicate_mode.proto
Outdated
| message ReplicateStatus { | ||
| enum Mode { | ||
| MAJORITY = 0; // the standard mode. Replicate logs to majority peer. | ||
| MS_AUTOSYNC = 1; // master-slave mode. Replicate logs among 2 DCs. |
There was a problem hiding this comment.
How about "PS_AUTO"? "PS" stands for primary and secondary. Or "Active-Active".
There was a problem hiding this comment.
seems PS is harder for reader to guess its meaning. I'm thinking maybe just AUTOSYNC
proto/replicate_mode.proto
Outdated
| ASYNC = 1; // raft logs need to sync to majority peers | ||
| SYNC_RECOVER = 2; // switching from ASYNC to SYNC mode | ||
| } | ||
| string label = 1; // the key of the label that used for distinguish different DC. |
proto/replicate_mode.proto
Outdated
| string label = 1; // the key of the label that used for distinguish different DC. | ||
| State state = 2; | ||
| uint64 recover_id = 3; // Unique ID for a recovery | ||
| int32 wait_sync_timeout_hint = 4; // Duration to wait before switching to SYNC by force |
Signed-off-by: disksing <[email protected]>
nolouch
previously approved these changes
Mar 24, 2020
BusyJay
previously approved these changes
Mar 24, 2020
HunDunDM
reviewed
Mar 24, 2020
proto/replicate_mode.proto
Outdated
| } | ||
| State state = 1; | ||
| uint64 recover_id = 2; // Unique ID for a recovery | ||
| } |
Signed-off-by: disksing <[email protected]>
BusyJay
approved these changes
Mar 24, 2020
BusyJay
reviewed
Apr 1, 2020
| package replicate_mode; | ||
|
|
||
| // The replicate status sync from PD to TiKV. | ||
| message ReplicateStatus { |
There was a problem hiding this comment.
Maybe we need to name it as ReplicationStatus?
There was a problem hiding this comment.
I think it ok. You can send a PR.
5kbpers
pushed a commit
to 5kbpers/kvproto
that referenced
this pull request
Aug 17, 2020
Signed-off-by: disksing <[email protected]> Signed-off-by: 5kbpers <[email protected]>
overvenus
pushed a commit
that referenced
this pull request
Aug 18, 2020
* cdc: add regions field for reducing message of resolved ts Signed-off-by: 5kbpers <[email protected]> * pdpb: add replicate_mode (#584) Signed-off-by: disksing <[email protected]> Signed-off-by: 5kbpers <[email protected]> * replicate_mode: change recover-id to state-id (#594) Signed-off-by: disksing <[email protected]> * replicate: add unknown region state (#595) Signed-off-by: disksing <[email protected]> * *: update name and script (#597) Signed-off-by: Jay Lee <[email protected]> Signed-off-by: 5kbpers <[email protected]> * support batch coprocessor (#586) Add batch coprocessor function for TiFlash Engine. Signed-off-by: 5kbpers <[email protected]> * pd: add UpdateServiceGCSafePoint method (#603) * pd: add UpdateServiceGCSafePoint method Signed-off-by: Shafreeck Sea <[email protected]> Signed-off-by: 5kbpers <[email protected]> * Add end_key_exclude field to SstMeta and distinguish restoring of RawKv (#581) * Add end_key_exclusive field to SSTMeta * Add is_raw_kv field to download request * Revert changes of unrelated go files Signed-off-by: MyonKeminta <[email protected]> * build Co-authored-by: MyonKeminta <[email protected]> Signed-off-by: 5kbpers <[email protected]> * Revert "cdc: add regions field for reducing message of resolved ts" This reverts commit c382b16. Signed-off-by: 5kbpers <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: Jay <[email protected]> Co-authored-by: Han Fei <[email protected]> Co-authored-by: Shafreeck Sea <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
daimashusheng
pushed a commit
to daimashusheng/kvproto
that referenced
this pull request
Sep 2, 2021
Signed-off-by: disksing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing [email protected]
See PD issue tikv/pd#2272 for detail.