This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
*: reduce dumpling accessing database and information_schema usage to improve its stability (#305) #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 1bd7db8
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #305
What problem does this PR solve?
fix #298 and fix #296 and fix #310
What is changed and how it works?
Try to dump the whole table directly if we meet some errors when we try to split tables into several chunks. cfb258a
Reduce accessing
SelectedFieldandSelectedLeninfo from database d3ba1e8Remove the usage of
information_schema1a0d9c4, 7f7cf58, b333bea, 088b5ba, 7dac228, bdb3c26Fix the bug that dumpling
finishedRowsis not accurate if we retry in chunks. ff398a4Fix the bug that dumpling dumps unlocked tables for consistency lock 7f7cf58
Fix the bug of
no-schemaargument's wrong output 09d257dCheck List
Tests
Side effects
Related changes
Release note