try dump whole table when fail to pick field

pingcap · Jun 30, 2021 · cfb258a · cfb258a
1 parent 292cbe6
commit cfb258a
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/v4/export/dump.go b/v4/export/dump.go
@@ -446,13 +446,10 @@ func (d *Dumper) concurrentDumpTable(tctx *tcontext.Context, conn *sql.Conn, met
 		return d.concurrentDumpTiDBTables(tctx, conn, meta, taskChan)
 	}
 	field, err := pickupPossibleField(db, tbl, conn, conf)
-	if err != nil {
-		return err
-	}
-	if field == "" {
+	if err != nil || field == "" {
 		// skip split chunk logic if not found proper field
 		tctx.L().Warn("fallback to sequential dump due to no proper field",
-			zap.String("database", db), zap.String("table", tbl))
+			zap.String("database", db), zap.String("table", tbl), zap.Error(err))
 		return d.dumpWholeTableDirectly(tctx, conn, meta, taskChan, "", 0, 1)
 	}