Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: Use open-protocol instead of default protocol and add missing params (#7407) #7453

Merged
merged 2 commits into from
Feb 14, 2022
Merged

ticdc: Use open-protocol instead of default protocol and add missing params (#7407) #7453

merged 2 commits into from
Feb 14, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 22, 2022 •
edited by hfxsd
Loading

This is an automated cherry-pick of #7407

What is changed, added or deleted? (Required)

  • Use open-protocol instead of default protocol.
  • Fix some wrong default values.(compressionType/max-batch-size)
  • Fix some typos

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4. labels Jan 22, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2022
Merged
14 tasks
@ti-chi-bot ti-chi-bot requested a review from TomShawn January 22, 2022 02:20
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2022
@TomShawn TomShawn removed the v5.4 This PR/issue applies to TiDB v5.4. label Jan 24, 2022
@Rustin170506
Resolve conflicts
08d4850 
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506 Rustin170506 force-pushed the cherry-pick-7407-to-release-4.0 branch from 7dce5a1 to 08d4850 Compare February 14, 2022 02:30
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2022
hfxsd
hfxsd approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2022
@Rustin170506
add new line
da4a393 
Signed-off-by: hi-rustin <[email protected]>
@hfxsd
Copy link
Collaborator

hfxsd commented Feb 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: da4a393

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022
@ti-chi-bot ti-chi-bot merged commit bd3b262 into pingcap:release-4.0 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Rustin170506 Rustin170506

@hfxsd hfxsd

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @hfxsd @Rustin170506 @TomShawn