Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: Use open-protocol instead of default protocol and add missing params #8047

Merged
merged 20 commits into from
Dec 31, 2021
Merged

ticdc: Use open-protocol instead of default protocol and add missing params #8047

merged 20 commits into from
Dec 31, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 22, 2021 •
edited
Loading

Signed-off-by: hi-rustin [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Use open-protocol instead of default protocol.
  • Fix some wrong default values.(compressionType/max-batch-size)
  • Fix some typos

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Need modification after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 22, 2021 06:14
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2021
@TomShawn TomShawn added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Dec 22, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 22, 2021
@Rustin170506 Rustin170506 added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Dec 22, 2021
zier-one
zier-one reviewed Dec 22, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/ticdc-open-api.md Outdated Show resolved Hide resolved
ticdc/ticdc-open-api.md Outdated Show resolved Hide resolved
@Rustin170506
Address comments
2265f09 
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506
Fix typo
53dace5 
Signed-off-by: hi-rustin <[email protected]>
zier-one
zier-one reviewed Dec 22, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@Rustin170506
Fix missing protocol
cab6738 
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506
Address comment
136f360 
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506 Rustin170506 mentioned this pull request Dec 22, 2021
Merged
@Rustin170506
Copy link
Member Author

/hold

Waiting for pingcap/tiflow#4036 landed.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2021
@Rustin170506
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2021
@Rustin170506
Add missing params
6f14318 
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506 Rustin170506 changed the title ticdc: Use open-protocol instead of default protocol ticdc: Use open-protocol instead of default protocol and add missing params Dec 27, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 31, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8088.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 31, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#8047
974868c 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 31, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8089.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 31, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#8047
efce26c 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 31, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8090.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8091.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 31, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#8047
d192547 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 31, 2021
Merged
11 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 31, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#8047
3417a24 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 31, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8092.

@en-jin19 en-jin19 self-assigned this Jan 4, 2022
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 13, 2022
@hfxsd hfxsd mentioned this pull request Jan 13, 2022
Merged
14 tasks
This was referenced Jan 22, 2022
Merged
Merged
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Jan 25, 2022
@ti-chi-bot
ticdc: Use open-protocol instead of default protocol and add missing …
695d521 
…params (#8047) (#8088)
ti-chi-bot added a commit that referenced this pull request Jan 27, 2022
@ti-chi-bot
ticdc: Use open-protocol instead of default protocol and add missing …
86e0b9e 
…params (#8047) (#8090)
Rustin170506 pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 27, 2022
@ti-chi-bot @Rustin170506
ticdc: Use open-protocol instead of default protocol and add missing …
e6e7bb8 
…params (pingcap#8047)
ti-chi-bot added a commit that referenced this pull request Feb 7, 2022
@ti-chi-bot
ticdc: add missing params (#8047) (#8089)
0673505
ti-chi-bot added a commit that referenced this pull request Feb 7, 2022
@ti-chi-bot
ticdc: add missing params (#8047) (#8091)
2307e14
ti-chi-bot added a commit that referenced this pull request Feb 9, 2022
@ti-chi-bot
ticdc: add missing params (#8047) (#8092)
47696f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en-jin19 en-jin19 en-jin19 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@zier-one zier-one zier-one approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees

@hfxsd hfxsd

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Rustin170506 @ti-chi-bot @TomShawn @zier-one @hfxsd @3AceShowHand @en-jin19