-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check-before-deployment: Add info about chronyd/chronyc on CentOS 8 #5283
check-before-deployment: Add info about chronyd/chronyc on CentOS 8 #5283
Conversation
/cc @King-Dylan @pepezzzz |
@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @pepezzzz |
@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @ethercflow |
We don't support CentOS 8 yet. It's not fully tested. |
This list has "CentOS: 7.3 or later". If CentOS 8 is not supported this should probably be changed to exclude CentOS 8. It looks like Ubuntu is also using chrony now: https://ubuntu.com/blog/ubuntu-bionic-using-chrony-to-configure-ntp |
Could you please do that in this PR? Thanks! |
- RHEL/OEL/CentOS 8 is not supported yet pingcap#5283 (comment) - Start with removing Ubuntu 16.04 pingcap#4943 - Mention CentOS 8 Linux and CentOS 8 Stream pingcap#4943 (comment) - Mention that Fedora, Debian, etc is likely to work but not supported.
I've created #5587 for this |
Shall we also update "On CentOS 8 you need to use |
efdb2c6
to
2443208
Compare
@TomShawn PTAL |
On CentOS 8 Chrony is used by default or NTP services. - https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_basic_system_settings/using-chrony-to-configure-ntp#sect-checking_if_chrony_is_synchronized
2443208
to
c426d9b
Compare
Co-authored-by: Daniël van Eeden <[email protected]>
Co-authored-by: Daniël van Eeden <[email protected]>
Co-authored-by: TomShawn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-status LGT1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2cd96cf
|
In response to a cherrypick label: new pull request created: #5730. |
In response to a cherrypick label: new pull request created: #5731. |
/translation done |
In response to a cherrypick label: failed to apply #5283 on top of branch "release-5.0":
|
In response to a cherrypick label: failed to apply #5283 on top of branch "release-4.0":
|
On CentOS 8 Chrony is used by default for NTP services.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?