Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-before-deployment: Add info about chronyd/chronyc on CentOS 8 #5283

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 9, 2021

On CentOS 8 Chrony is used by default for NTP services.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2021
@TomShawn
Copy link
Contributor

/cc @King-Dylan @pepezzzz
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation doing
/assign Joyinqin
/label require-LGT1

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 12, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @King-Dylan @pepezzzz
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation doing
/assign Joyinqin
/label require-LGT1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from King-Dylan April 12, 2021 02:45
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021
@TomShawn
Copy link
Contributor

/cc @pepezzzz

@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pepezzzz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TomShawn
Copy link
Contributor

/cc @ethercflow

@ti-chi-bot ti-chi-bot requested a review from ethercflow April 12, 2021 03:01
@lucklove
Copy link
Member

lucklove commented May 6, 2021

We don't support CentOS 8 yet. It's not fully tested.

@dveeden
Copy link
Contributor Author

dveeden commented May 6, 2021

We don't support CentOS 8 yet. It's not fully tested.

https://github.com/pingcap/docs/blob/master/hardware-and-software-requirements.md#linux-os-version-requirements

This list has "CentOS: 7.3 or later". If CentOS 8 is not supported this should probably be changed to exclude CentOS 8.

It looks like Ubuntu is also using chrony now: https://ubuntu.com/blog/ubuntu-bionic-using-chrony-to-configure-ntp

@TomShawn
Copy link
Contributor

TomShawn commented May 7, 2021

This list has "CentOS: 7.3 or later". If CentOS 8 is not supported this should probably be changed to exclude CentOS 8.

Could you please do that in this PR? Thanks!

dveeden added a commit to dveeden/docs that referenced this pull request May 7, 2021
- RHEL/OEL/CentOS 8 is not supported yet
  pingcap#5283 (comment)

- Start with removing Ubuntu 16.04
  pingcap#4943

- Mention CentOS 8 Linux and CentOS 8 Stream
  pingcap#4943 (comment)

- Mention that Fedora, Debian, etc is likely to work but not supported.
@dveeden
Copy link
Contributor Author

dveeden commented May 7, 2021

This list has "CentOS: 7.3 or later". If CentOS 8 is not supported this should probably be changed to exclude CentOS 8.

Could you please do that in this PR? Thanks!

I've created #5587 for this

@TomShawn
Copy link
Contributor

TomShawn commented May 8, 2021

This list has "CentOS: 7.3 or later". If CentOS 8 is not supported this should probably be changed to exclude CentOS 8.

Could you please do that in this PR? Thanks!

I've created #5587 for this

Shall we also update "On CentOS 8 you need to use chronyc tracking instead of ntpstat if you are using chronyd instead of ntpd." in this PR?

@dveeden dveeden force-pushed the check-before-deployment__centos8 branch from efdb2c6 to 2443208 Compare May 20, 2021 15:32
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2021
@dveeden
Copy link
Contributor Author

dveeden commented May 20, 2021

@TomShawn PTAL

@dveeden dveeden force-pushed the check-before-deployment__centos8 branch from 2443208 to c426d9b Compare May 20, 2021 15:34
@dveeden dveeden requested a review from TomShawn May 31, 2021 09:03
TomShawn and others added 2 commits May 31, 2021 19:48
Co-authored-by: Daniël van Eeden <[email protected]>
Co-authored-by: Daniël van Eeden <[email protected]>
check-before-deployment.md Outdated Show resolved Hide resolved
@dveeden dveeden requested a review from TomShawn June 1, 2021 05:28
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jun 1, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cd96cf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2021
@ti-chi-bot ti-chi-bot merged commit c1aa2bc into pingcap:master Jun 1, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5730.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5731.

@Joyinqin
Copy link
Contributor

Joyinqin commented Jun 7, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 7, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #5283 on top of branch "release-5.0":

failed to git commit: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #5283 on top of branch "release-4.0":

failed to git commit: exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants