Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-before-deployment: add info about chronyd/chronyc on CentOS 8 #6412

Merged
merged 6 commits into from
Jul 8, 2021
Merged

check-before-deployment: add info about chronyd/chronyc on CentOS 8 #6412

merged 6 commits into from
Jul 8, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jun 7, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

On CentOS 8 Chrony is used by default for NTP services.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 7, 2021 03:59
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2021
@Joyinqin Joyinqin added needs-cherry-pick-release-4.0 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jun 7, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 7, 2021
@ti-chi-bot
Copy link
Member

@Joyinqin: These labels are not set on the issue: translation/doing.

In response to this:

/translation done
/remove-translation doing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 7, 2021
@ti-chi-bot
Copy link
Member

@Joyinqin: These labels are not set on the issue: translation/doing.

In response to this:

/translation done
/remove-translation doing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Joyinqin Joyinqin requested a review from lucklove June 7, 2021 04:01
@Joyinqin Joyinqin changed the title check-before-deployment: Add info about chronyd/chronyc on CentOS 8 check-before-deployment: add info about chronyd/chronyc on CentOS 8 Jun 7, 2021
@Joyinqin Joyinqin marked this pull request as ready for review June 7, 2021 05:50
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2021
lucklove
lucklove approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 06398c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/rebase

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b8bc0ec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit a9c1973 into pingcap:master Jul 8, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6649.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6650.

This was referenced Jul 8, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6651.

ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
check-before-deployment: add info about chronyd/chronyc on CentOS 8 (#…
5a2c576 
…6412) (#6649)
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
check-before-deployment: add info about chronyd/chronyc on CentOS 8 (#…
dae28ec 
…6412) (#6650)
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
check-before-deployment: add info about chronyd/chronyc on CentOS 8 (#…
369a0c5 
…6412) (#6651)
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@Joyinqin @3AceShowHand
check-before-deployment: add info about chronyd/chronyc on CentOS 8 (p…
22724d0 
…ingcap#6412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@lucklove lucklove lucklove approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @ti-chi-bot @TomShawn @lucklove