Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Local-backend in tidb-lightning-backends.md #5278

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Clarify Local-backend in tidb-lightning-backends.md #5278

merged 2 commits into from
Apr 9, 2021

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Apr 9, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2021
@yikeke yikeke added needs-cherry-pick-4.0 needs-cherry-pick-master Should cherry pick this PR to master branch. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2021
@yikeke yikeke requested a review from IANTHEREAL April 9, 2021 07:45
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2021
@yikeke yikeke requested a review from TomShawn April 9, 2021 07:46
@TomShawn
Copy link
Contributor

TomShawn commented Apr 9, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@glorv
Copy link
Contributor

glorv commented Apr 9, 2021

LGTM

1 similar comment
@IANTHEREAL
Copy link
Contributor

LGTM

@yikeke yikeke merged commit 868f416 into release-5.0 Apr 9, 2021
@yikeke yikeke deleted the yikeke-patch-1 branch April 9, 2021 07:52
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 9, 2021
@yikeke @ti-srebot
cherry pick pingcap#5278 to release-4.0
534b568 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5279

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 9, 2021
@yikeke @ti-srebot
cherry pick pingcap#5278 to master
5305db9 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5280

ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
Clarify Local-backend in tidb-lightning-backends.md (#5278) (#5279)
33b0baa
ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
Clarify Local-backend in tidb-lightning-backends.md (#5278) (#5280)
0a37ab5
@Joyinqin Joyinqin mentioned this pull request Apr 9, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented Apr 9, 2021

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 9, 2021
@Joyinqin
Copy link
Contributor

Joyinqin commented Apr 9, 2021

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 9, 2021
This was referenced Apr 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Joyinqin Joyinqin

Labels
needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yikeke @TomShawn @ti-chi-bot @glorv @IANTHEREAL @ti-srebot @Joyinqin