Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Local-backend in tidb-lightning-backends.md #6006

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Clarify Local-backend in tidb-lightning-backends.md #6006

merged 2 commits into from
Apr 13, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 9, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Clarify Local-backend in tidb-lightning-backends.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/traslation from-docs

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/cc @yikeke @TomShawn

@ti-chi-bot ti-chi-bot requested review from TomShawn and yikeke April 9, 2021 08:18
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@yikeke yikeke requested review from glorv and removed request for TomShawn April 9, 2021 08:19
@glorv
Copy link
Contributor

glorv commented Apr 9, 2021

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 13, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/MERGE

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 95206eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit da1a786 into pingcap:master Apr 13, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#6006 to release-4.0
99833a5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#6006 to release-5.0
500b920 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6022

@Joyinqin Joyinqin deleted the tidb-lightning-backends-patch branch April 13, 2021 02:38
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Clarify Local-backend in tidb-lightning-backends.md (#6006) (#6022)
4482201
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Clarify Local-backend in tidb-lightning-backends.md (#6006) (#6021)
2843525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @ti-chi-bot @glorv @yikeke @ti-srebot