Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system variable: add tidb_allow_fallback_to_tikv #4781

Merged
merged 11 commits into from
Mar 25, 2021
Merged

system variable: add tidb_allow_fallback_to_tikv #4781

merged 11 commits into from
Mar 25, 2021

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Feb 3, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add tidb_allow_fallback_to_tikv into system variables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Feb 3, 2021
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Feb 3, 2021
Merged
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Feb 23, 2021
Merged
@xuyifangreeneyes xuyifangreeneyes marked this pull request as ready for review February 24, 2021 08:15
@xuyifangreeneyes xuyifangreeneyes changed the title system variable: add tidb_enable_tiflash_fallback_tikv system variable: add tidb_enable_engine_fallback Feb 24, 2021
morgo
morgo reviewed Mar 2, 2021
View reviewed changes
system-variables.md Outdated
Comment on lines 1077 to 1082

### tidb_enable_engine_fallback

- Scope: SESSION | GLOBAL
- Default value: OFF
- This variable controls whether to retry execution with another engine when the used engine's failure causes execution failure of SQL statement. If the variable turns on, currently TiDB supports retrying execution with TiKV when TiFlash's failure causes execution failure of SQL statement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options in this page are in alphabetical order (the order which they were added to the server is not useful to end-users). Please move it to the correct place :-)

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. status/require-change Needs the author to address comments. labels Mar 11, 2021
@ti-chi-bot ti-chi-bot requested review from qw4990 and winoros March 11, 2021 12:30
@ti-srebot
Copy link
Contributor

@xuyifangreeneyes, please update your pull request.

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/small Changes of a small size. labels Mar 15, 2021
@xuyifangreeneyes xuyifangreeneyes changed the title system variable: add tidb_enable_engine_fallback system variable: add tidb_allow_fallback_to_tikv Mar 15, 2021
@ti-srebot
Copy link
Contributor

@xuyifangreeneyes, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@xuyifangreeneyes, please update your pull request.

@qiancai
Copy link
Collaborator

qiancai commented Mar 22, 2021

/cc @qiancai

@ti-chi-bot ti-chi-bot requested a review from qiancai March 22, 2021 03:28
@ti-srebot
Copy link
Contributor

@xuyifangreeneyes, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

qiancai
qiancai reviewed Mar 22, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn TomShawn mentioned this pull request Mar 23, 2021
Merged
11 tasks
TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Mar 24, 2021

/label v5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 24, 2021
@yikeke
Copy link
Contributor

yikeke commented Mar 24, 2021

@morgo PTAL again

@morgo
Copy link
Contributor

morgo commented Mar 24, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2021
@TomShawn
Copy link
Contributor

/remove-status require-change
/lgtm

@ti-chi-bot ti-chi-bot removed the status/require-change Needs the author to address comments. label Mar 25, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 095b35b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0

@yikeke yikeke merged commit 0d2f898 into pingcap:master Mar 25, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 25, 2021
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#4781 to release-5.0
71ceb27 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5103

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021
@ti-srebot
system variable: add tidb_allow_fallback_to_tikv (#4781) (#5103)
b722374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@TomShawn TomShawn TomShawn left review comments

@morgo morgo morgo left review comments

@qw4990 qw4990 Awaiting requested review from qw4990

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xuyifangreeneyes @CLAassistant @ti-srebot @qiancai @yikeke @morgo @TomShawn @ti-chi-bot