Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TiDB Binlog #18569

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Aug 13, 2024

What is changed, added or deleted? (Required)

This PR adds deprecation warnings or notes to docs related to TiDB Binlog

Note: The status of TiDB Binlog in TiDB Features | PingCAP Docs will be updated in another PR that is particularly for updating the status of all v8.3 features on that page. So it is not updated in this PR to avoid conflict.

image

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.3 labels Aug 13, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2024
@lilin90 lilin90 self-assigned this Aug 13, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@lilin90 lilin90 requested a review from hfxsd August 13, 2024 10:04
Copy link
Collaborator

@benmeadowcroft benmeadowcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few different suggestions and skipped a few changes that are repetitive to ones where I have made those suggestions.

Given the history of TiDB Binlog deprecation (replication in v7.5.0 and full in v8.3.0) the two suggestions are:

  1. For pages where the historical context is important we should be clear that deprecations started in v7.5.0
  2. For pages where the deprecation is important to note, but not a TiDB Binlog specific page, a more concise annotation that the Binlog feature is deprecated should be sufficient.

basic-features.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
ecosystem-tool-user-guide.md Outdated Show resolved Hide resolved
faq/deploy-and-maintain-faq.md Outdated Show resolved Hide resolved
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-table.md Outdated Show resolved Hide resolved
tidb-binlog-deployment-topology.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2024
@lilin90
Copy link
Member Author

lilin90 commented Aug 16, 2024

Thanks @benmeadowcroft! All your comments have been addressed.

@lilin90 lilin90 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@lilin90 lilin90 added for-release This PR relates to a TiDB release but does not have a tracked feature. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 19, 2024
Copy link

ti-chi-bot bot commented Aug 19, 2024

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 20, 2024
Copy link

ti-chi-bot bot commented Aug 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-20 01:46:08.281751942 +0000 UTC m=+229963.416202064: ☑️ agreed by hfxsd.

@lilin90 lilin90 added the lgtm label Aug 20, 2024
@lilin90
Copy link
Member Author

lilin90 commented Aug 20, 2024

/approve

Copy link

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit bb94d49 into pingcap:master Aug 20, 2024
9 checks passed
@lilin90 lilin90 deleted the deprecate-tidb-binlog-18346 branch August 20, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants