-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TiDB Binlog #18569
Deprecate TiDB Binlog #18569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a few different suggestions and skipped a few changes that are repetitive to ones where I have made those suggestions.
Given the history of TiDB Binlog deprecation (replication in v7.5.0 and full in v8.3.0) the two suggestions are:
- For pages where the historical context is important we should be clear that deprecations started in v7.5.0
- For pages where the deprecation is important to note, but not a TiDB Binlog specific page, a more concise annotation that the Binlog feature is deprecated should be sufficient.
Thanks @benmeadowcroft! All your comments have been addressed. |
@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added or deleted? (Required)
This PR adds deprecation warnings or notes to docs related to TiDB Binlog
Note: The status of TiDB Binlog in TiDB Features | PingCAP Docs will be updated in another PR that is particularly for updating the status of all v8.3 features on that page. So it is not updated in this PR to avoid conflict.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?