Add description about user ATTRIBUTE #11716

CbcWestwolf · 2022-10-21T03:35:13Z

What is changed, added or deleted? (Required)

Support ATTRIBUTE and COMMENT in CREATE USER and ALTER USER statements
Add a new column user_attributes to mysql.user, and add a new view information_schema.user_attributes

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): *: support ATTRIBUTE and COMMENT in CREATE USER and ALTER USER statements tidb#38201

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-10-21T03:35:14Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Oreoxmt
qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CbcWestwolf · 2022-10-21T12:44:04Z

/cc xiongjiwei

xiongjiwei · 2022-10-24T03:33:09Z

sql-statements/sql-statement-show-columns-from.md

+| Host                   | char(255)     | utf8mb4_bin | NO   | PRI | <null>  |       | select,insert,update,references |         |
+| User                   | char(32)      | utf8mb4_bin | NO   | PRI | <null>  |       | select,insert,update,references |         |
+| authentication_string  | text          | utf8mb4_bin | YES  |     | <null>  |       | select,insert,update,references |         |
+| plugin                 | char(64)      | utf8mb4_bin | YES  |     | <null>  |       | select,insert,update,references |         |


<null> should be NULL?

information-schema/information-schema-user-attributes.md

Co-authored-by: Aolin <[email protected]>

sql-statements/sql-statement-create-user.md

information-schema/information-schema-user-attributes.md

Co-authored-by: Aolin <[email protected]>

Oreoxmt

Rest LGTM

information-schema/information-schema-user-attributes.md

Co-authored-by: Aolin <[email protected]>

qiancai · 2022-10-24T10:44:23Z

information-schema/information-schema-user-attributes.md

+{{< copyable "sql" >}}
+


Suggested change

{{< copyable "sql" >}}

This copy syntax is no longer needed for the current docs website. Please remove it from this doc.

information-schema/information-schema-user-attributes.md

Co-authored-by: Grace Cai <[email protected]>

sql-statements/sql-statement-alter-user.md

Co-authored-by: Grace Cai <[email protected]>

information-schema/information-schema.md

Co-authored-by: Grace Cai <[email protected]>

CbcWestwolf · 2022-10-30T23:52:59Z

/verify

information-schema/information-schema-user-attributes.md

sql-statements/sql-statement-alter-user.md

sql-statements/sql-statement-create-user.md

Oreoxmt · 2022-11-01T05:12:20Z

sql-statements/sql-statement-alter-user.md

+```
+Query OK, 0 rows affected (0.02 sec)
+```


建议改成 SELECT * FROM user_attributes; 的输出

sql-statements/sql-statement-alter-user.md

Co-authored-by: Aolin <[email protected]>

sql-statements/sql-statement-alter-user.md

sql-statements/sql-statement-create-user.md

Co-authored-by: Aolin <[email protected]>

CbcWestwolf · 2022-11-01T08:54:13Z

attribute 里面 {"key": null} 是删除 key 哈，不会出现在查询结果中

sql-statements/sql-statement-alter-user.md

Oreoxmt

LGTM

information-schema/information-schema-user-attributes.md

Co-authored-by: Grace Cai <[email protected]>

qiancai · 2022-11-07T06:33:39Z

/merge

ti-chi-bot · 2022-11-07T06:33:41Z

This pull request has been accepted and is ready to merge.

Commit hash: 298c23c

qiancai · 2022-11-07T06:46:20Z

/merge

Add description about USER ATTRIBUTE

6c9aa88

ti-chi-bot requested a review from TomShawn October 21, 2022 03:35

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2022

qiancai added v6.4 This PR/issue applies to TiDB v6.4. translation/doing This PR’s assignee is translating this PR. labels Oct 21, 2022

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 21, 2022

qiancai added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Oct 21, 2022

qiancai self-assigned this Oct 21, 2022

ti-chi-bot requested a review from xiongjiwei October 21, 2022 12:44

qiancai removed the request for review from TomShawn October 24, 2022 03:23

xiongjiwei reviewed Oct 24, 2022

View reviewed changes

xiongjiwei approved these changes Oct 24, 2022

View reviewed changes

Update

1fa7aea

Oreoxmt reviewed Oct 24, 2022

View reviewed changes

information-schema/information-schema-user-attributes.md Outdated Show resolved Hide resolved

Update information-schema/information-schema-user-attributes.md

e0c14d4

Co-authored-by: Aolin <[email protected]>

Oreoxmt reviewed Oct 24, 2022

View reviewed changes

Oreoxmt requested review from Oreoxmt and qiancai October 24, 2022 06:57

Apply suggestions from code review

67ae93c

Co-authored-by: Aolin <[email protected]>

Oreoxmt approved these changes Oct 24, 2022

View reviewed changes

information-schema/information-schema-user-attributes.md Outdated Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 24, 2022

Update information-schema/information-schema-user-attributes.md

00383ef

Co-authored-by: Aolin <[email protected]>

qiancai reviewed Oct 24, 2022

View reviewed changes

information-schema/information-schema-user-attributes.md Outdated Show resolved Hide resolved

CbcWestwolf and others added 2 commits October 24, 2022 19:44

update

b1047cf

Apply suggestions from code review

ad0240e

Co-authored-by: Grace Cai <[email protected]>

qiancai reviewed Oct 25, 2022

View reviewed changes

sql-statements/sql-statement-alter-user.md Show resolved Hide resolved

Update information-schema/information-schema-user-attributes.md

9730d36

Co-authored-by: Grace Cai <[email protected]>

qiancai reviewed Oct 28, 2022

View reviewed changes

information-schema/information-schema.md Outdated Show resolved Hide resolved

qiancai mentioned this pull request Oct 28, 2022

Add description about user ATTRIBUTE pingcap/docs#11084

Merged

14 tasks

qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 28, 2022

Apply suggestions from code review

6c97b51

Co-authored-by: Grace Cai <[email protected]>

Oreoxmt reviewed Nov 1, 2022

View reviewed changes

information-schema/information-schema-user-attributes.md Outdated Show resolved Hide resolved

Apply suggestions from code review

2a735b1

Oreoxmt reviewed Nov 1, 2022

View reviewed changes

Apply suggestions from code review

3d51549

Co-authored-by: Aolin <[email protected]>

Oreoxmt approved these changes Nov 1, 2022

View reviewed changes

CbcWestwolf and others added 3 commits November 1, 2022 16:44

Update sql-statements/sql-statement-alter-user.md

d4ec8bf

Co-authored-by: Aolin <[email protected]>

Apply suggestions from code review

8104b78

Co-authored-by: Aolin <[email protected]>

Update

d4d51d0

Oreoxmt mentioned this pull request Nov 2, 2022

Add description about tidb_auth_token authentication #11824

Merged

13 tasks

Oreoxmt reviewed Nov 2, 2022

View reviewed changes

sql-statements/sql-statement-alter-user.md Outdated Show resolved Hide resolved

make ci happy

cd2032c

Oreoxmt reviewed Nov 2, 2022

View reviewed changes

sql-statements/sql-statement-alter-user.md Show resolved Hide resolved

Remove Mysql compatibility

5d0808d

Oreoxmt approved these changes Nov 2, 2022

View reviewed changes

qiancai reviewed Nov 4, 2022

View reviewed changes

information-schema/information-schema-user-attributes.md Outdated Show resolved Hide resolved

Update information-schema/information-schema-user-attributes.md

298c23c

Co-authored-by: Grace Cai <[email protected]>

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022

qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022

ti-chi-bot merged commit daf8ca2 into pingcap:master Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add description about user ATTRIBUTE #11716

Add description about user ATTRIBUTE #11716

CbcWestwolf commented Oct 21, 2022

ti-chi-bot commented Oct 21, 2022 •

edited

Loading

CbcWestwolf commented Oct 21, 2022

xiongjiwei Oct 24, 2022 •

edited

Loading

Oreoxmt left a comment

qiancai Oct 24, 2022

qiancai Oct 24, 2022

CbcWestwolf commented Oct 30, 2022

Oreoxmt Nov 1, 2022

CbcWestwolf commented Nov 1, 2022

Oreoxmt left a comment

qiancai commented Nov 7, 2022

ti-chi-bot commented Nov 7, 2022

qiancai commented Nov 7, 2022

Add description about user ATTRIBUTE #11716

Add description about user ATTRIBUTE #11716

Conversation

CbcWestwolf commented Oct 21, 2022

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Oct 21, 2022 • edited Loading

CbcWestwolf commented Oct 21, 2022

xiongjiwei Oct 24, 2022 • edited Loading

Choose a reason for hiding this comment

Oreoxmt left a comment

Choose a reason for hiding this comment

qiancai Oct 24, 2022

Choose a reason for hiding this comment

qiancai Oct 24, 2022

Choose a reason for hiding this comment

CbcWestwolf commented Oct 30, 2022

Oreoxmt Nov 1, 2022

Choose a reason for hiding this comment

CbcWestwolf commented Nov 1, 2022

Oreoxmt left a comment

Choose a reason for hiding this comment

qiancai commented Nov 7, 2022

ti-chi-bot commented Nov 7, 2022

qiancai commented Nov 7, 2022

ti-chi-bot commented Oct 21, 2022 •

edited

Loading

xiongjiwei Oct 24, 2022 •

edited

Loading