Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: table no need exist when drop (#985) #990

Merged
merged 3 commits into from
Sep 4, 2020
Merged

syncer: table no need exist when drop (#985) #990

merged 3 commits into from
Sep 4, 2020

Conversation

ti-srebot
Copy link

cherry-pick #985 to release-2.0

What problem does this PR solve?

close #975

What is changed and how it works?

  • do not check table exist when drop table because we have added IF EXIST for DROP TABLE statement.

Tests

  • Integration test

@ti-srebot ti-srebot mentioned this pull request Sep 4, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 4, 2020
@csuzhangxc
Copy link
Member

/run-all-tests

reading http://goproxy.pingcap.net/github.com/lance6716/retool/@v/dev.info: 502 Bad Gateway

csuzhangxc
csuzhangxc approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 4, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 4, 2020
@csuzhangxc csuzhangxc merged commit b13adb9 into pingcap:release-2.0 Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @csuzhangxc @GMHDBJD