This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: table no need exist when drop #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/normal
lance6716
reviewed
Sep 3, 2020
tests/all_mode/run.sh
Outdated
| run_sql_source1 "drop table if exists \`all_mode\`.\`tb1\`;" | ||
| run_sql_source2 "drop table if exists \`all_mode\`.\`tb2\`;" | ||
| run_sql_source2 "drop table if exists \`all_mode\`.\`tb2\`;" | ||
| sleep 2 |
There was a problem hiding this comment.
how about retry and check downstream table dropped, maybe quicker than 2s
There was a problem hiding this comment.
I want to check no error exist.
There was a problem hiding this comment.
just want to replace sleep 2s this line 🤣
There was a problem hiding this comment.
check log in 5bb5f63
csuzhangxc
reviewed
Sep 3, 2020
| @@ -2100,8 +2100,6 @@ func (s *Syncer) trackDDL(usedSchema string, sql string, tableNames [][]*filter. | |||
| shouldSchemaExist = true | |||
| case *ast.DropTableStmt: | |||
| shouldExecDDLOnSchemaTracker = true | |||
| shouldSchemaExist = true | |||
There was a problem hiding this comment.
Do we need to handle shouldSchemaExist for case *ast.DropDatabaseStmt?
There was a problem hiding this comment.
We create it if not exist below. But actually no need. Address in 56bf87f
|
LGTM |
|
cherry pick to release-2.0 in PR #990 |
ti-srebot
added
already-cherry-pick-2.0
csuzhangxc
added
status/LGT2
14 tasks
csuzhangxc
pushed a commit
that referenced
this pull request
Sep 4, 2020
Co-authored-by: gmhdbjd <[email protected]>
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #975
What is changed and how it works?
IF EXISTfor DROP TABLE statement.Tests