Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: fix wrong conversion for mysql BIT (#876) #886

Merged
merged 5 commits into from
Aug 13, 2020
Merged

syncer: fix wrong conversion for mysql BIT (#876) #886

merged 5 commits into from
Aug 13, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

manually cherry-pick #876

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 12, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Aug 13, 2020

/run-all-tests

GMHDBJD
GMHDBJD reviewed Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 13, 2020
@lance6716 lance6716 added status/WIP This PR is still work in progress and removed status/WIP This PR is still work in progress labels Aug 13, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

csuzhangxc
csuzhangxc approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 13, 2020
@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Aug 13, 2020
@lance6716 lance6716 merged commit e1c31e8 into pingcap:release-1.0 Aug 13, 2020
@lance6716 lance6716 deleted the cp876 branch August 13, 2020 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @GMHDBJD @csuzhangxc