This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: fix wrong conversion for mysql BIT #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/normal
lance6716
added
the
needs-cherry-pick-release-1.0
|
this change was introduced in https://github.com/pingcap/tidb-enterprise-tools/pull/5/commits/300bfa154021daec805827c7410d0233e6d33306 , seems avoiding overflow. But now it won't overflow. BTW, jenkins can't open now |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
================================================
- Coverage 57.0981% 55.8686% -1.2296%
================================================
Files 205 221 +16
Lines 21104 23106 +2002
================================================
+ Hits 12050 12909 +859
- Misses 7890 8880 +990
- Partials 1164 1317 +153 |
lance6716
added
status/PTAL
csuzhangxc
added
status/LGT1
GMHDBJD
added
status/LGT2
|
cherry pick to release-1.0 failed |
lance6716
added a commit
to lance6716/dm
that referenced
this pull request
Aug 12, 2020
lance6716
added a commit
that referenced
this pull request
Aug 13, 2020
lance6716
added
already-cherry-pick-1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #874
What is changed and how it works?
BIT type support up to 64 bit so returned int64 in binlog (I guess), don't need to convert to string
Need to know why choose convert to string orginally 🤔
Check List
Tests
Code changes
Side effects
Related changes