Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: don't auto-resume for dump unit error #866 #872

Merged
merged 4 commits into from
Aug 7, 2020
Merged

*: don't auto-resume for dump unit error #866 #872

merged 4 commits into from
Aug 7, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Aug 7, 2020 •
edited
Loading

What problem does this PR solve?

manually cherry-pick #866, close #837

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020 •
edited
Loading

Codecov Report

Merging #872 into master will decrease coverage by 1.0523%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #872        +/-   ##
================================================
- Coverage   57.0981%   56.0458%   -1.0524%     
================================================
  Files           205        220        +15     
  Lines         21104      22867      +1763     
================================================
+ Hits          12050      12816       +766     
- Misses         7890       8740       +850     
- Partials       1164       1311       +147

@lance6716
Copy link
Collaborator Author

/run-all-tests

GMHDBJD
GMHDBJD reviewed Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 7, 2020
csuzhangxc
csuzhangxc reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 7, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Aug 7, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 merged commit 0e34545 into pingcap:master Aug 7, 2020
@lance6716 lance6716 deleted the cp866 branch August 7, 2020 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

do not "auto resume" for errors in dump unit
3 participants
@lance6716 @csuzhangxc @GMHDBJD