Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: don't auto-resume for dump unit error #866

Merged
merged 6 commits into from
Aug 7, 2020
Merged

*: don't auto-resume for dump unit error #866

merged 6 commits into from
Aug 7, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Aug 6, 2020 •
edited
Loading

What problem does this PR solve?

close #837

What is changed and how it works?

move logic together, check PR does take effect

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to master

@lance6716 lance6716 added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #866 into release-1.0 will increase coverage by 0.5291%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-1.0       #866        +/-   ##
===================================================
+ Coverage      57.2665%   57.7957%   +0.5291%     
===================================================
  Files              161        168         +7     
  Lines            16741      17176       +435     
===================================================
+ Hits              9587       9927       +340     
- Misses            6206       6283        +77     
- Partials           948        966        +18

csuzhangxc
csuzhangxc reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dm/worker/task_checker.go Outdated Show resolved Hide resolved
@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 7, 2020
@lance6716
Copy link
Collaborator Author

@GMHDBJD PTAL

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Aug 7, 2020

/run-all-tests

GMHDBJD
GMHDBJD approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 7, 2020
@lance6716 lance6716 merged commit 21a6e6e into pingcap:release-1.0 Aug 7, 2020
@lance6716 lance6716 deleted the dump-unit-err branch August 7, 2020 06:39
@lance6716 lance6716 removed the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Aug 7, 2020
lance6716 added a commit to lance6716/dm that referenced this pull request Aug 7, 2020
@lance6716
*: don't auto-resume for dump unit error pingcap#866
bac1b55
@lance6716 lance6716 mentioned this pull request Aug 7, 2020
Merged
lance6716 added a commit that referenced this pull request Aug 7, 2020
@lance6716
*: don't auto-resume for dump unit error #866 (#872)
0e34545
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @GMHDBJD @csuzhangxc