Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

checkpoint: cherrypick flush global checkpoint when first time flush checkpoint #763

Merged
merged 1 commit into from
Jul 1, 2020
Merged

checkpoint: cherrypick flush global checkpoint when first time flush checkpoint #763

merged 1 commit into from
Jul 1, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 28, 2020

manually cherrypick #758

What problem does this PR solve?

flush global checkpoint when first time flush checkpoint

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 28, 2020
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #763 into release-1.0 will increase coverage by 0.5989%.
The diff coverage is 65.3465%.

@@                 Coverage Diff                 @@
##           release-1.0       #763        +/-   ##
===================================================
+ Coverage      57.2665%   57.8655%   +0.5989%     
===================================================
  Files              161        167         +6     
  Lines            16741      16604       -137     
===================================================
+ Hits              9587       9608        +21     
+ Misses            6206       6123        -83     
+ Partials           948        873        -75

WangXiangUSTC
WangXiangUSTC reviewed Jun 28, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 28, 2020
@lance6716
Copy link
Collaborator

LGTM

@lance6716 lance6716 added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 1, 2020
@GMHDBJD GMHDBJD merged commit 0c10af0 into pingcap:release-1.0 Jul 1, 2020
@GMHDBJD GMHDBJD deleted the cherrypickFixGloablPoint branch July 1, 2020 06:55
@csuzhangxc csuzhangxc added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Jul 15, 2020
@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @lance6716 @WangXiangUSTC @csuzhangxc